For her, there seems to be a process that allows keeping German citizenship if one acquires foreign citizenship. Being a dual citizen is always the best option if one views citizenship as a matter of convenience.
OTOH, he’d likely need to renounce his US citizenship if he acquired German citizenship, but he could easily gain permanent residence via marriage without renouncing.[/quote]
Interesting. We know a couple of Germans who have renounced German citizenship and obtained U.S. citizenship. I would think that people would choose dual citizenship whenever possible. But I believe the people we know plan to stay in the U.S., so they might have had different ideas. I agree with you that dual citizenship is almost always preferable, especially if one can maintain access to the benefits available in many European countries.